Skip to content

DataViews: Add groupByField support to grid layout #70752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2025
Merged

DataViews: Add groupByField support to grid layout #70752

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5339afb
DataViews: Add groupByField support to grid layout
oandregal Jul 17, 2025
2ceb8b8
Update API to use view.sort.grouped instead
oandregal Jul 17, 2025
117f4c0
Enable all layouts to test that grouping is maintained
oandregal Jul 17, 2025
aeac8fc
Prepend field label in group separator
oandregal Jul 17, 2025
fef3502
Revert "Update API to use view.sort.grouped instead"
oandregal Jul 18, 2025
703aa6c
Sort by groupByField
oandregal Jul 18, 2025
5b8663f
Improve LLM generated code
oandregal Jul 18, 2025
1a733ad
Let "Type: value" be translated
oandregal Jul 21, 2025
d97929e
Document in readme
oandregal Jul 21, 2025
e2235dc
Update test data to latest
oandregal Jul 21, 2025
8ac0e2c
Use a Map instead of object to hold the groups
oandregal Jul 21, 2025
4aef87a
Add changelog
oandregal Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prepend field label in group separator
  • Loading branch information
@oandregal
oandregal committed Jul 21, 2025
commit aeac8fc6841e1f643aff1ea13aa041f5ca6e6070
8 changes: 4 additions & 4 deletions packages/dataviews/src/dataviews-layouts/grid/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,11 @@ function ViewGrid< Item >( {
: {};

// Group data by sort.field if sort.grouped is true
const groupField = view.sort?.grouped
? fields.find( ( f ) => f.id === view.sort?.field )
: null;
const groupedData = view.sort?.grouped
? data.reduce( ( groups: { [ key: string ]: typeof data }, item ) => {
const groupField = fields.find(
( f ) => f.id === view.sort?.field
);
const groupValue = groupField?.getValue
? groupField.getValue( { item } )
: ( item as any )[ view.sort?.field! ];
Expand All @@ -322,7 +322,7 @@ function ViewGrid< Item >( {
( [ groupName, groupItems ] ) => (
<VStack key={ groupName } spacing={ 2 }>
<h3 className="dataviews-view-grid__group-header">
{ groupName }
{ groupField?.label }: { groupName }
</h3>
<Grid
gap={ 8 }
Expand Down