Skip to content

Cherry-picked bug fixes for 6.8.2 #70557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 8, 2025
Merged

Cherry-picked bug fixes for 6.8.2 #70557

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8410f63
Navigation Link: Don't check validity when block editing is disabled …
Mamaduka Mar 19, 2025
4d35d12
Navigation Link: Optimize 'getBlockParentsByBlockName' selector call …
Mamaduka Mar 19, 2025
54572c0
Navigation Link: Improve performance by only requesting entities when…
Mamaduka Mar 24, 2025
e8a0af6
Query Loop: Don't overwrite the 'query.inherit' attribute value (#69698)
Mamaduka Apr 7, 2025
5e80e98
Block Editor: Remove truncation from media tab preview tooltips (#69741)
Sukhendu2002 Mar 28, 2025
0303378
Image: Avoid stale URL when reselecting the same image from the libra…
Mamaduka Apr 29, 2025
08682c6
Post Template: Don't rely on the default 'ignore_sticky' REST API val…
Mamaduka May 13, 2025
f52edfc
MediaPlaceholder: Fix Regression with media URL input type to allow a…
Mayank-Tripathi32 May 5, 2025
25ebdc1
DOM: Add summary element to focusable elements (#70051)
t-hamano May 6, 2025
48803db
Button: Limit scope of width style for link (#70054)
t-hamano May 22, 2025
cacd2c8
Details: Enable all non-interactive formats (#68741)
im3dabasia Mar 28, 2025
595b997
Details Block: Fix keyboard accessibility issues and allow list view …
yogeshbhutkar Jun 2, 2025
4353d71
URL: Handle HTML entities and ampersand in 'cleanForSlug' (#70078)
Mamaduka May 7, 2025
a7e5cb5
Remove screencast.com embed block variation. (#70480)
peterwilsoncc Jun 21, 2025
a96bc3d
Fix Floating UI packages dependencies (#70553)
t-hamano Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Navigation Link: Don't check validity when block editing is disabled (#… 
…69627)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
  • Loading branch information
@Mamaduka @fabiankaegy @t-hamano
3 people authored and t-hamano committed Jun 30, 2025
commit 8410f6303be0cf31b1762284f80848e3fb3f72d1
13 changes: 12 additions & 1 deletion packages/block-library/src/navigation-link/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
store as blockEditorStore,
getColorClassName,
useInnerBlocksProps,
useBlockEditingMode,
} from '@wordpress/block-editor';
import { isURL, prependHTTP, safeDecodeURI } from '@wordpress/url';
import { useState, useEffect, useRef } from '@wordpress/element';
Expand Down Expand Up @@ -99,15 +100,25 @@ const useIsInvalidLink = ( kind, type, id ) => {
const isPostType =
kind === 'post-type' || type === 'post' || type === 'page';
const hasId = Number.isInteger( id );
const blockEditingMode = useBlockEditingMode();

const postStatus = useSelect(
( select ) => {
if ( ! isPostType ) {
return null;
}

// Fetching the posts status is an "expensive" operation. Especially for sites with large navigations.
// When the block is rendered in a template or other disabled contexts we can skip this check in order
// to avoid all these additional requests that don't really add any value in that mode.
if ( blockEditingMode === 'disabled' ) {
return null;
}

const { getEntityRecord } = select( coreStore );
return getEntityRecord( 'postType', type, id )?.status;
},
[ isPostType, type, id ]
[ isPostType, blockEditingMode, type, id ]
);

// Check Navigation Link validity if:
Expand Down