Skip to content

Try using responsive images in dataview grid layouts #70493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 31, 2025
Merged

Try using responsive images in dataview grid layouts #70493

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c51c52b
Try using responsive images in dataview grid layouts
tellthemachines Jun 23, 2025
11c4cb6
Move determination of sizes to dataviews
tellthemachines Jun 24, 2025
8ed1094
Simplify grid logic and sizes
tellthemachines Jun 25, 2025
e6fb1f7
use range of image widths for grid size picker
tellthemachines Jun 30, 2025
4bb82b8
Make picker discrete and improve breakpoints
tellthemachines Jul 1, 2025
fc7a29d
remove unused prop
tellthemachines Jul 1, 2025
a4cb98b
ref no worky again
tellthemachines Jul 1, 2025
4f74b4c
smol improvement
tellthemachines Jul 1, 2025
792b887
Update to use an object instead of sizes string and fix grid size at max
tellthemachines Jul 3, 2025
ad0f857
Adjust table max img width
tellthemachines Jul 3, 2025
dfcc42d
Change `mediaAppearance` to the more generic `config`
tellthemachines Jul 7, 2025
29cc5de
Change `size` to `sizes`
tellthemachines Jul 30, 2025
653e108
Explain magic number in comment.
tellthemachines Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust table max img width
  • Loading branch information
@tellthemachines
tellthemachines committed Jul 29, 2025
commit ad0f8570b6612711ce0eb6525366874ee840b27f
2 changes: 1 addition & 1 deletion packages/dataviews/src/dataviews-layouts/table/column-primary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ColumnPrimary< Item >( {
<mediaField.render
item={ item }
field={ mediaField }
mediaAppearance={ { maxImageWidth: '32px' } }
mediaAppearance={ { maxImageWidth: '60px' } }
/>
</div>
) }
Expand Down