TypeScript: migrate dom-ready package to TS#70467
TypeScript: migrate dom-ready package to TS#70467kushagra-goyal-14 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kushagra-goyal-14! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
|
Seems like #67671 has already migrated this package to TS and is open, thus closing this PR |
1 participant
What?
Part of #67691
Migrating the dom-ready package to TypeScript.
Why?
To enhance DX and add type safety.
How?
By porting the code and tests to TypeScript, inlining the
() => voidcallback type and removing the obsolete@typedef Callback.Since Doctrine was removed from
docgenin PR #28615, the tooling now understands inline function types. This completes the original TODO to drop theCallbacktypedef and use() => voiddirectly in JSDoc and signatures.Testing Instructions
Typecheck and unit tests.