Fix: Update post-publish panel to use taxonomy label instead of hardcoded "Tags" by shrivastavanolo · Pull Request #70410 · WordPress/gutenberg

shrivastavanolo · 2025-06-13T09:16:22Z

What?

Updates the MaybeTagsPanel component in the post-publish panel to use the dynamic taxonomy label for the post_tag taxonomy instead of hardcoded strings like "Tags".

Why?

Previously, the post-publish panel used hardcoded "Tags" strings in its UI, even if the taxonomy_labels_post_tag filter was used to rename the taxonomy (e.g., to "Keywords"). This led to inconsistencies between the main editor sidebar (which showed the correct custom label) and the pre-publish panel (which did not).

This PR resolves that by fetching the labels.name from the core data store via useSelect and using it in all strings via sprintf().

How?

Introduced a useSelect call to get the name label of the post_tag taxonomy.
Replaced all hardcoded “Tags” strings with sprintf() calls that dynamically insert the taxonomy label.

Testing Instructions

Add something like the following to a plugin or your themes functions.php file.

add_filter(
	'taxonomy_labels_post_tag',
	function( object $labels ): object {
		$singular_name = 'Keyword';
		$plural_name   = 'Keywords';
		return (object) [
			'name'                  => $plural_name,
			'singular_name'         => $singular_name,
			'menu_name'             => $plural_name,
			'all_items'             => "All {$plural_name}",
			'new_item_name'         => "New {$singular_name} Name",
			'add_new_item'          => "Add New {$singular_name}",
			'edit_item'             => "Edit {$singular_name}",
			'update_item'           => "Update {$singular_name}",
			'view_item'             => "View {$singular_name}",
			'add_or_remove_items'   => "Add or remove {$plural_name}",
			'search_items'          => "Search {$plural_name}",
			'not_found'             => "No {$plural_name} found",
			'no_terms'              => "No {$plural_name}",
			'items_list'            => "{$plural_name} list",
			'items_list_navigation' => "{$plural_name} list navigation",
		];
	}
);

Create a new post using Gutenberg.
See that "tags" are changed to "keywords" in the sidebar.
Don't add any tags/keywords before clicking on publish (and make sure to have the pre publish checks enabled). See that it says "Add Keywords" and "Keywords help users and search engines..." instead of "Add tags" etc. now

Screenshots or screencast

Before

After

…ng in Maybe tags panel

github-actions · 2025-06-13T09:51:51Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ShreyaShrivastava@192.168.1.12, @lakrisgubben.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: shreyashrivastava@192.168.1.12, lakrisgubben.

Co-authored-by: shrivastavanolo <shreya0shrivastava@git.wordpress.org>
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: kathrynwp <zoonini@git.wordpress.org>
Co-authored-by: skorasaurus <skorasaurus@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

yogeshbhutkar

Works as advertised.

t-hamano

Thanks for the PR!

I think we should respect the add_new_item field instead of using the taxonomy name itself.

Example:

const Test = () => {
	const taxonomyLabels = useSelect( ( select ) => {
		const taxonomy = select( coreStore ).getTaxonomy( 'post_tag' );
		return taxonomy?.labels;
	}, [] );
	return taxonomyLabels?.add_new_item ?? __( 'Add tag' );
};

shrivastavanolo · 2025-06-16T12:58:35Z

@t-hamano thanks for the review! Yeah, that makes sense. I changed the code to use add_new_items like so -

Default tag labels:

Modified tag labels ( add_new_item -> 'Add New Keyword' ):

Do you think it'll be better to convert panelBodyTitle to sentence case/title case before displaying or just to respect the case?

t-hamano · 2025-06-16T13:35:35Z

@shrivastavanolo

Do you think it'll be better to convert "panelBodyTitle" to sentence case/title case before displaying or just to respect the case?

I don't recommend controlling the character case programmatically because it won't work properly in non-English locales.

Additionally, I don't need to use add_new_item in the description - we'll need to use the name property on the description to keep the original text, i.e. Tags help... instead of Add tag to help....

t-hamano

LGTM!

…oded "Tags" (WordPress#70410) * refactor: use tags taxonomy name label instead of hardcoded tags string in Maybe tags panel * refactor: use add_new_item instead of name for taxonomy label * refactor: use add_new_item label for panel title * i18n: add i18n for static labels --------- Unlinked contributors: shreyashrivastava@192.168.1.12, lakrisgubben. Co-authored-by: shrivastavanolo <shreya0shrivastava@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: kathrynwp <zoonini@git.wordpress.org> Co-authored-by: skorasaurus <skorasaurus@git.wordpress.org>

refactor: use tags taxonomy name label instead of hardcoded tags stri…

a368168

…ng in Maybe tags panel

shrivastavanolo changed the title ~~Fix post-publish panel to use taxonomy label instead of hardcoded "Tags"~~ Fix: Update post-publish panel to use taxonomy label instead of hardcoded "Tags" Jun 13, 2025

shrivastavanolo marked this pull request as ready for review June 13, 2025 09:51

yogeshbhutkar approved these changes Jun 13, 2025

View reviewed changes

t-hamano added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Jun 16, 2025

t-hamano reviewed Jun 16, 2025

View reviewed changes

t-hamano added the General Interface Parts of the UI which don't fall neatly under other labels. label Jun 16, 2025

Merge branch 'WordPress:trunk' into add/maybe-tags-panel-label-change

1e08599

shrivastavanolo added 3 commits June 16, 2025 21:36

refactor: use add_new_item instead of name for taxonomy label

16d81cd

refactor: use add_new_item label for panel title

ee0a1a1

i18n: add i18n for static labels

ce5fe3f

t-hamano approved these changes Jun 17, 2025

View reviewed changes

t-hamano merged commit de11ef9 into WordPress:trunk Jun 17, 2025
58 of 60 checks passed

github-actions bot added this to the Gutenberg 21.1 milestone Jun 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Update post-publish panel to use taxonomy label instead of hardcoded "Tags"#70410

Fix: Update post-publish panel to use taxonomy label instead of hardcoded "Tags"#70410
t-hamano merged 5 commits intoWordPress:trunkfrom
shrivastavanolo:add/maybe-tags-panel-label-change

shrivastavanolo commented Jun 13, 2025

Uh oh!

github-actions bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

yogeshbhutkar left a comment

Uh oh!

t-hamano left a comment

Uh oh!

shrivastavanolo commented Jun 16, 2025 •

edited

Loading

Uh oh!

t-hamano commented Jun 16, 2025

Uh oh!

t-hamano left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shrivastavanolo commented Jun 13, 2025

What?

Why?

How?

Testing Instructions

Screenshots or screencast

Before

After

Uh oh!

github-actions bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

yogeshbhutkar left a comment

Choose a reason for hiding this comment

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

shrivastavanolo commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t-hamano commented Jun 16, 2025

Uh oh!

t-hamano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jun 13, 2025 •

edited

Loading

shrivastavanolo commented Jun 16, 2025 •

edited

Loading