Skip to content

refactor: convert createColorHOC to functional component. #70408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 22 commits into from
Aug 13, 2026
Merged

refactor: convert createColorHOC to functional component. #70408

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2a0996f
refactor: convert class component to functional component with hooks …
USERSATOSHI Jun 13, 2025
ec5ee1b
fix: add lazy state init before initial render
USERSATOSHI Jun 13, 2025
b8f2a49
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 13, 2025
7fb6cb7
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 13, 2025
1cf2300
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 14, 2025
6a1d063
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 15, 2025
0fa7d70
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 16, 2025
089580e
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 16, 2025
1d91c89
Merge branch 'WordPress:trunk' into try/refactor-with-color-functiona…
USERSATOSHI Jun 18, 2025
7585da5
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jul 15, 2025
23fb43c
merge trunk
USERSATOSHI Jun 10, 2026
fb89ef9
Merge branch 'try/refactor-with-color-functional-component' of https:…
USERSATOSHI Jun 10, 2026
b88e1bc
Merge branch 'trunk' into try/refactor-with-color-functional-component
USERSATOSHI Jun 10, 2026
1d3269a
fix: compute derived color state during render, not in effect
USERSATOSHI Jun 10, 2026
08e8fab
test: assert for only first arg
USERSATOSHI Jun 10, 2026
87407bb
Merge branch 'trunk' into try/refactor-with-color-functional-component
Mamaduka Jun 23, 2026
5bd382d
More cleanup
Mamaduka Jun 23, 2026
00f71e1
refactor(with-colors): merge color getter/setter into single useMemo …
USERSATOSHI Jun 25, 2026
7132af8
refactor(with-colors): merge color getter/setter into single useMemo …
USERSATOSHI Jun 25, 2026
b20fecc
chore: fix lint error
USERSATOSHI Jun 25, 2026
cfbfee9
Merge remote-tracking branch 'origin/trunk' into try/refactor-with-co…
USERSATOSHI Aug 13, 2026
f5c034e
fix: remove stale dependency-group comment causing lint error
USERSATOSHI Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix lint error
  • Loading branch information
@USERSATOSHI
USERSATOSHI committed Jun 25, 2026
commit b20fecc4b0a5c0b4b177cdeeaf1a95b4f79ad1b3
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/colors/with-colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function createColorHOC( colorTypes, withColorPalette ) {
return result;
}, [ attributes, _colors, setAttributes ] );

const colorUtils = useMemo(
const colorUtils = useMemo(
() => ( {
getMostReadableColor: ( colorValue ) =>
getMostReadableColor( _colors, colorValue ),
Expand Down
Loading