[WIP] Image: Do not render attachment link option if attachment pages are disabled #70406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@yogeshbhutkar Thanks for working on this issue. Before tackling this problem, we may want to read #56019 and consider what approach we should take. |
t-hamano
added
[Type] Bug
Contributor
Author
|
Based on the developments in the discussion within the tagged issue, I think it's appropriate to close this PR, as introducing the option as a block editor setting has been ruled out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70403
WP 6.4 introduced the database option
wp_attachment_pages_enabledto control visibility/generation of attachment pages (Ref. https://make.wordpress.org/core/2023/10/16/changes-to-attachment-pages/ )This PR uses the above option to conditionally render the "Link to attachment page" option within the
ImageURLInputUIcomponent.Why?
Currently, the Image block always displays the "Link to attachment page" option, even when
wp_attachment_pages_enabledis set to 0 (i.e., attachment pages are disabled).How?
This PR exposes the
wp_attachment_pages_enabledsetting to the editor and uses it to conditionally display the "Link to attachment page" option in the Image block.Testing Instructions
wp_attachment_pages_enabledis set to0(i.e., disabled).core/imageblock and attach an image.Link ControlwithinBlock Toolbar, verify that theLink to attachment pageoption is not present.wp_attachment_pages_enabledto1and confirm that theLink to attachment pageis now accessible.Testing Instructions for Keyboard
Same.
Screenshots