Fix: Incorrect style handle in RTL style registration for wp-list-reusable-blocks #70402
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @iamsandeepdahiya! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Good catch! This style is used in the wp_block post type list, and the import button is correctly positioned now.
http://localhost:8888/wp-admin/edit.php?post_type=wp_block
Before
After
t-hamano
added
[Type] Bug
|
Note:
|
t-hamano
removed
the
[Type] Bug
…70402) Co-authored-by: iamsandeepdahiya <sandeepdahiya@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
2 participants
This PR fixes an issue in
gutenberg_override_style()where the handle 'wp-list-reusable-block' was incorrect. The correct handle 'wp-list-reusable-blocks' is already used in thegutenberg_override_style()call. Mismatch would prevent RTL styles from being applied correctly.Why?
It ensures that RTL support is added to the correctly registered style handle. Without this fix, the RTL version of the stylesheet won't be loaded in right-to-left languages (like Arabic, Hebrew, etc.) because WordPress can't find the correct style to apply RTL logic to.