-
Notifications
You must be signed in to change notification settings - Fork 4.6k
block-attributes: Add role attribute explanation
#70361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small suggestion :) Other than that this is good to go! Thanks for the addition!
|
It might be worth also linking to the dev note Or making sure all the same contents are covered: https://make.wordpress.org/core/2024/10/20/miscellaneous-block-editor-changes-in-wordpress-6-7/#stabilized-role-property-for-block-attributes |
fabiankaegy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship It :)
…ordPress#70361) Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>

What?
Closes : #65614
Related comment: #65484 (review)
Add a missing role field, in the
block-attributes.mdfor clarity among block developersWhy?
The role field was stabilised in WordPress 6.7, but was not exposed in the developer documentation, in this https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/block-api/block-attributes.md
How?
Updated the Docs.