Skip to content

Conversation

@im3dabasia
Copy link
Contributor

What?

Closes : #65614
Related comment: #65484 (review)

Add a missing role field, in the block-attributes.md for clarity among block developers

Why?

The role field was stabilised in WordPress 6.7, but was not exposed in the developer documentation, in this https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/block-api/block-attributes.md

How?

Updated the Docs.

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Jun 9, 2025
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small suggestion :) Other than that this is good to go! Thanks for the addition!

@fabiankaegy
Copy link
Member

It might be worth also linking to the dev note Or making sure all the same contents are covered: https://make.wordpress.org/core/2024/10/20/miscellaneous-block-editor-changes-in-wordpress-6-7/#stabilized-role-property-for-block-attributes

@im3dabasia
Copy link
Contributor Author

It might be worth also linking to the dev note

I have added a link to the dev note the final appearance of the document looks something like this.

Let me know your thoughts if any improvements are needed.

image

@im3dabasia im3dabasia requested a review from fabiankaegy June 11, 2025 05:01
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship It :)

@fabiankaegy fabiankaegy merged commit 8b8cade into WordPress:trunk Jun 11, 2025
60 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 11, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ordPress#70361)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document role attribute property

2 participants