iAPI: Fix duplicated nested regions #70302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
luisherranz
requested changes
Jun 3, 2025
Member
luisherranz
left a comment
luisherranz
left a comment
There was a problem hiding this comment.
Oh wait, can you include a changelog?
DAreRodz
force-pushed
the
fix/iapi-nested-router-regions
branch
from
5be6352 to
89fbac0
Compare
Contributor
Author
|
@luisherranz, changelog updated! |
luisherranz
approved these changes
Jun 4, 2025
Member
luisherranz
left a comment
luisherranz
left a comment
There was a problem hiding this comment.
Perfect, thank you David!
10 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Add failing test * Add test to test data-wp-interactive topmost behaviour * Fix the tests * Update changelog --------- Co-authored-by: luisherranz <luisherranz@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevents duplicating nested router regions after a client-side navigation.
Nested regions may appear when an interactive block with a router region (e.g., the Query block) is placed within another interactive block with its router region (which could be another Query block instance). In this case, the nested router region is rendered twice: as part of the parent block's Preact application and as a separate Preact application, resulting in duplicated HTML.
Additionally, since a requirement of
data-wp-router-regionis that it must be in the top-mostdata-wp-interactiveelement, this PR ensures that it ignores all regions that do not meet this requirement.Why?
Nested router regions should not be processed; only the top-most region should, as nested regions become part of the same Preact application.
How?
Changing the selector to only take into account the regions that are not nested and that also include a top-most
data-wp-interactiveelement.The PR includes e2e tests for this bug fix.