Skip to content

Comment Title: Refactor settings panel to use ToolsPanel #70246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

Comment Title: Refactor settings panel to use ToolsPanel #70246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa41a8
Comment Title: Refactor settings panel to use ToolsPanel
SainathPoojary May 28, 2025
e9c54fd
Comment Title: Update hasValue and onDeselect logic
SainathPoojary May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 53 additions & 15 deletions packages/block-library/src/comments-title/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,21 @@ import {
} from '@wordpress/block-editor';
import { __, _n, sprintf } from '@wordpress/i18n';
import { useEntityProp } from '@wordpress/core-data';
import { PanelBody, ToggleControl } from '@wordpress/components';
import {
ToggleControl,
__experimentalToolsPanel as ToolsPanel,
__experimentalToolsPanelItem as ToolsPanelItem,
} from '@wordpress/components';
import { useState, useEffect } from '@wordpress/element';
import { useSelect } from '@wordpress/data';
import apiFetch from '@wordpress/api-fetch';
import { addQueryArgs } from '@wordpress/url';

/**
* Internal dependencies
*/
import { useToolsPanelDropdownMenuProps } from '../utils/hooks';

export default function Edit( {
attributes: {
textAlign,
Expand Down Expand Up @@ -53,6 +62,8 @@ export default function Edit( {
return getSettings().__experimentalDiscussionSettings;
} );

const dropdownMenuProps = useToolsPanelDropdownMenuProps();

useEffect( () => {
if ( isSiteEditor ) {
// Match the number of comments that will be shown in the comment-template/edit.js placeholder
Expand Down Expand Up @@ -111,24 +122,51 @@ export default function Edit( {

const inspectorControls = (
<InspectorControls>
<PanelBody title={ __( 'Settings' ) }>
<ToggleControl
__nextHasNoMarginBottom
<ToolsPanel
label={ __( 'Settings' ) }
resetAll={ () => {
setAttributes( {
showPostTitle: true,
showCommentsCount: true,
} );
} }
dropdownMenuProps={ dropdownMenuProps }
>
<ToolsPanelItem
label={ __( 'Show post title' ) }
checked={ showPostTitle }
onChange={ ( value ) =>
setAttributes( { showPostTitle: value } )
isShownByDefault
hasValue={ () => ! showPostTitle }
onDeselect={ () =>
setAttributes( { showPostTitle: true } )
}
/>
<ToggleControl
__nextHasNoMarginBottom
>
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Show post title' ) }
checked={ showPostTitle }
onChange={ ( value ) =>
setAttributes( { showPostTitle: value } )
}
/>
</ToolsPanelItem>
<ToolsPanelItem
label={ __( 'Show comments count' ) }
checked={ showCommentsCount }
onChange={ ( value ) =>
setAttributes( { showCommentsCount: value } )
isShownByDefault
hasValue={ () => ! showCommentsCount }
onDeselect={ () =>
setAttributes( { showCommentsCount: true } )
}
/>
</PanelBody>
>
<ToggleControl
__nextHasNoMarginBottom
label={ __( 'Show comments count' ) }
checked={ showCommentsCount }
onChange={ ( value ) =>
setAttributes( { showCommentsCount: value } )
}
/>
</ToolsPanelItem>
</ToolsPanel>
</InspectorControls>
);

Expand Down
Loading