Skip to content

Base Styles: Update to modern Sass module system #70135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 21, 2025
Merged

Base Styles: Update to modern Sass module system #70135

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e5fbaba
Base Styles: Update to modern Sass module system
t-hamano May 15, 2025
f8bee1d
Update changelog
t-hamano May 15, 2025
d36776b
Adjust the sort order
t-hamano May 15, 2025
29598b6
Update packages/base-styles/CHANGELOG.md
t-hamano May 16, 2025
d8675e6
functions: use `color.channel` instead of `color.red|green|blue`
t-hamano May 16, 2025
8546617
Mixins: Use namespace
t-hamano May 16, 2025
f48ed53
Don't use color.channel
t-hamano May 16, 2025
cc9fd5a
Mixins: Place nested rules after declarations
t-hamano May 16, 2025
6e74fb7
Functions: Make hex-to-rgb function backward compatible
t-hamano May 16, 2025
b46bb75
Mixin: Fix radio-control radius mixin style
t-hamano May 16, 2025
4164c35
Default Custom Props: fix sass errors
t-hamano May 16, 2025
056bdaf
Update README
t-hamano May 16, 2025
43e6c38
Colors: Remove unused statement
t-hamano May 21, 2025
27982e5
Default custom properties: fix function import
t-hamano May 21, 2025
2ebc1d0
Default custom properties: add missing @use functions import
t-hamano May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Functions: Make hex-to-rgb function backward compatible
  • Loading branch information
@t-hamano
t-hamano committed May 16, 2025
commit 6e74fb78befc0480f5fdfc19ab422738e8b0769d
16 changes: 11 additions & 5 deletions packages/base-styles/_functions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@
*/

@use "sass:color";
@use "sass:meta";

@function hex-to-rgb($hex) {
/*
* We should use the color.channel() function instead of color.red(), color.green(), color.blue().
* However, the Sass currently used by the Gutenberg project does not support color.channel().
* We should update to color.channel() once the entire Gutenberg project has completed the migration to
* Dart Sass and the Sass version is updated.
* TODO: `color.{red|green|blue}` will trigger a deprecation warning in Dart Sass,
* but the Sass used by the Gutenberg project doesn't support `color.channel()` yet,
* so we can't migrate to it at this time.
* In the future, after the Gutenberg project has been fully migrated to Dart Sass,
* Remove this conditional statement and use only `color.channel()`.
*/
@return color.red($hex), color.green($hex), color.blue($hex);
@if meta.function-exists("channel", "color") {
@return color.channel($hex, "red"), color.channel($hex, "green"), color.channel($hex, "blue");
} @else {
@return color.red($hex), color.green($hex), color.blue($hex);
}
}
Loading