[WP6.8.1] ToggleGroupControl: Fix active background for empty string value #70000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
fix/toggle-group-control-empty-string-value-6.8
branch
from
9064f75 to
5d646c3
Compare
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#70000 - WordPress/gutenberg#69998 - WordPress/gutenberg#70001 - WordPress/gutenberg#70006 - WordPress/gutenberg#69958 Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: Yogesh Bhutkar <yogesh.bhutkar@rtcamp.com> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: Sourav61 <sourav08@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine. Fixes #63366. git-svn-id: https://develop.svn.wordpress.org/branches/6.8@60199 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine. Fixes #63366. Built from https://develop.svn.wordpress.org/branches/6.8@60199 git-svn-id: http://core.svn.wordpress.org/branches/6.8@59535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. git-svn-id: https://develop.svn.wordpress.org/trunk@60205 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. Built from https://develop.svn.wordpress.org/trunk@60205 git-svn-id: http://core.svn.wordpress.org/trunk@59541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. Built from https://develop.svn.wordpress.org/trunk@60205 git-svn-id: https://core.svn.wordpress.org/trunk@59541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jonnynews
pushed a commit
to spacedmonkey/wordpress-develop
that referenced
this pull request
Sep 24, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. git-svn-id: https://develop.svn.wordpress.org/trunk@60205 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is for the
wp/6.8branch and is equivalent to #69969.How?
I simply cherry-picked #69969 (accde16).
Testing Instructions
See #69969.