Skip to content

Remove css grid rule causing the issue#69992

Closed
n2erjo00 wants to merge 1 commit intoWordPress:trunkfrom
n2erjo00:fix/draf-saved-button-content-overflow
Closed

Remove css grid rule causing the issue#69992
n2erjo00 wants to merge 1 commit intoWordPress:trunkfrom
n2erjo00:fix/draf-saved-button-content-overflow

Conversation

@n2erjo00
Copy link
Copy Markdown
Contributor

What?

Closes #68065

Why?

This PR aims to fix "Draft saved" message colliding with the editor header button.

How?

Tested various ways to apply CSS around this but came to the conclusion that the grid template rule inside media query is causing the issue and removed it. Content no longer collides with "Draft saved" message

Testing Instructions

  1. This issue only replicates with Firefox
  2. Change WordPress localization to Germany (as per original issue instructions).
  3. Other way to test it to change "Draft message" translations to something really ludicrous to really push this solution to its limit.

Testing Instructions for Keyboard

Screenshots or screencast

Sample screenshots from Firefox, Brave and Safari

Screenshot 2025-04-27 at 21 29 07

Firefox 👆

Screenshot 2025-04-27 at 21 29 58

Brave 👆

Screenshot 2025-04-27 at 21 30 24

Safari 👆

Screenshots taken around the screen size described in the issue

Before After

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @placoderm.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: placoderm.

Co-authored-by: n2erjo00 <n2erjo00@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Apr 28, 2025
@t-hamano
Copy link
Copy Markdown
Contributor

Thanks for the PR!

Tested various ways to apply CSS around this but came to the conclusion that the grid template rule inside media query is causing the issue and removed it.

I think the document bar won't be aligned centrally if we remove this style. See:

header

Let's consider a more ideal approach.

@t-hamano t-hamano closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox UI: Save Draft button is broken for other languages

2 participants