Query Total: Add interactivity.clientNavigation block support#69661
Query Total: Add interactivity.clientNavigation block support#69661
Conversation
t-hamano
added
[Type] Enhancement
t-hamano
requested review from
ajitbohra,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'd suggest backporting this feature into 6.8 release, as some users may feel it's a bug if they can't use the client navigation. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
Cannot backport Enhancements in Beta/RC cycle :( |
|
If it's a small enhancement and there is a consensus or agreement, enhancements can be allowed to be backported even during the Beta/Rc cycle, no? 🤔 |
|
If it can become a "blessed" task, then I think it's okay. The general guideline is that only bug fixes are backported. You could share this in the leads channel for more feedback. |
|
That a block specifically created for the Query Loop block cannot be used without the "Force reloading the page" setting seems like a bug to me, not an enhancement. |
|
Posted the suggestion about backporting this PR on Slack: https://wordpress.slack.com/archives/C080HLPP2Q6/p1742806743015109 |
|
Based on the discussion on Slack, I'm backporting this PR to 6.8: https://wordpress.slack.com/archives/C080HLPP2Q6/p1742826838468909?thread_ts=1742806743.015109&cid=C080HLPP2Q6 |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.8 Editor Tasks
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: d907387 |
…ess#69661) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
6 participants
What?
Related:
block supportsforclientNavigationandinteractiveproperties onblock.jsonschema. #58132Adds
interactivity.clientNavigationsupport to the Query Total block in order to enable client navigation.Why?
The Query Total block is available only if the ancestor block is the Query Loop block, but we can't use the client navigation if the Query Loop block includes the Query Total block.
Screenshot - Notice modal when inserting the Query Total block into the Query Loop block with "Reload full page" disabled:
I don't see any reason why we can't add the interactivity support.
Testing Instructions
Screenshots or screencast
ab4ddc82c1c1818b8ab959b8848c7287.mp4