Fix: Solid color selected does not apply due to preset gradient#69642
Closed
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix: Solid color selected does not apply due to preset gradient#69642karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
This works well to let the selected solid color override the default gradient, however the color indicator in the sidebar does not update to reflect the new solid color. |
Contributor
Author
|
And also I have noticed it later that for global theme color this PR fixes the issue but for blocks it only works in the editor and the color in the FE doesn't update, So I have closed this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69634 #67055 #42105
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast