Skip to content

ActionModal: Add support for customisable focusOnMount #69609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2025
Merged

ActionModal: Add support for customisable focusOnMount #69609

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38d144a
feat: support customisable `focusOnMount`
yogeshbhutkar Mar 18, 2025
63032b9
fix: ensure `focusOnMount` defaults to true in ActionModal
yogeshbhutkar Mar 31, 2025
9f5598c
feat: add `modalFocusOnMount` property to all eligible actions
yogeshbhutkar Mar 31, 2025
56436aa
feat: add `modalFocusOnMount` property to ActionModal fixture
yogeshbhutkar Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: add modalFocusOnMount property to ActionModal fixture
  • Loading branch information
@yogeshbhutkar
yogeshbhutkar committed Apr 3, 2025
commit 56436aaba182ec2f8b0a421e912f5db797f63fce
1 change: 1 addition & 0 deletions packages/dataviews/src/components/dataviews/stories/fixtures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ export const actions: Action< SpaceObject >[] = [
isPrimary: true,
icon: trash,
hideModalHeader: true,
modalFocusOnMount: 'firstContentElement',
RenderModal: ( { items, closeModal } ) => {
return (
<VStack spacing="5">
Expand Down
Loading