Skip to content

fix: Remove empty space from figure tag and fix img tag alignment.#69267

Open
coder-rancho wants to merge 7 commits intoWordPress:trunkfrom
coder-rancho:fix/image-alignment-in-image-block
Open

fix: Remove empty space from figure tag and fix img tag alignment.#69267
coder-rancho wants to merge 7 commits intoWordPress:trunkfrom
coder-rancho:fix/image-alignment-in-image-block

Conversation

@coder-rancho
Copy link
Copy Markdown

What?

Closes #69255

Why?

After merging this PR, we'll be able to vertically align the image to the middle.

How?

  • Remove the hardcoded vertical-align: bottom.
  • Use line-height: 0 to remove empty space around <img> tag.

Testing Instructions

Screenshots or screencast

Before After
Image on the left is not vertically aligned with the text on the right. Image is perfectly aligned to the middle.
image image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 20, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @aialvi.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: aialvi.

Co-authored-by: coder-rancho <vyasnaman@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: stokesman <presstoke@git.wordpress.org>
Co-authored-by: hanneslsm <hanneslsm@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 20, 2025
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @coder-rancho! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Image Affects the Image Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image: hardcoded vertical alignment: bottom makes it impossible to correctly align images

2 participants