Skip to content

Fix: Better error handling when creating a new page from the inline link popover#68747

Open
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:fix/error-in-new-page-from-link-popover
Open

Fix: Better error handling when creating a new page from the inline link popover#68747
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:fix/error-in-new-page-from-link-popover

Conversation

@dhananjaykuber
Copy link
Copy Markdown
Contributor

@dhananjaykuber dhananjaykuber commented Jan 17, 2025

Fixes #57266

What?

Improves error handling when creating a new page from the inline link popover by providing user-friendly error messages and consistent error behavior with the Site Editor.

Why?

Previously, when errors occurred during page creation (e.g., network issues), technical error messages like "Cannot read properties of undefined" were shown to users. This provided poor user feedback and wasn't consistent with how errors are handled in the Site Editor.

How?

  • Added offline status check in the useCreatePage hook

Testing Instructions

  1. Open the Post Editor
  2. Select some text and click the link button in the toolbar
  3. Type something that doesn't match any existing post
  4. Click "Create page: [your text]" at the bottom of the suggestions
  5. Before clicking, turn off your internet connection (you can use browser dev tools Network tab's offline mode)
  6. Click the create page button
  7. Verify you see a snackbar notice saying "You are probably offline."
  8. Turn your internet back on and try again - the page should be created successfully

Screenshots or screencast

Screenshot 2025-01-17 at 5 28 36 PM

@dhananjaykuber dhananjaykuber marked this pull request as ready for review January 17, 2025 13:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 17, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 17, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@getdave getdave Awaiting requested review from getdave getdave is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better error handling when creating a new page from the inline link popover

1 participant

@dhananjaykuber