Skip to content

Fix: Empty state of custom field can cause SEO problem#68699

Open
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:fix/empty-state-of-heading-block
Open

Fix: Empty state of custom field can cause SEO problem#68699
dhananjaykuber wants to merge 1 commit intoWordPress:trunkfrom
dhananjaykuber:fix/empty-state-of-heading-block

Conversation

@dhananjaykuber
Copy link
Copy Markdown
Contributor

@dhananjaykuber dhananjaykuber commented Jan 16, 2025 •
edited
Loading

Fixes #66887

What?

Prevents empty heading tags from being rendered in the frontend when using block bindings or when heading content is empty.

Why?

Empty heading tags (<h1>, <h2>, etc.) can cause SEO issues as they create unnecessary markup in the page structure. This is particularly problematic when using block bindings where the heading content might be dynamically empty. The fix ensures better SEO practices by preventing empty heading tags from being output.

How?

Added empty content checks in both:

  1. The block's save.js to prevent empty headings from being saved
  2. The PHP render callback to prevent empty headings from being rendered

Testing Instructions

  1. Create a new post
  2. Add a heading block
  3. Leave it empty or delete its content
  4. Save and view the post
  5. Verify no empty heading tag is rendered in the frontend HTML

@dhananjaykuber dhananjaykuber changed the title fix: handle empty content in heading block rendering Fix: Empty state of custom field can cause SEO problem Jan 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 16, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Feature] Block bindings.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@dhananjaykuber dhananjaykuber marked this pull request as ready for review January 16, 2025 13:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 16, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: simonemanfre <webdesignsimone@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Jan 23, 2025

Hi
There is some additional context about empty blocks, including the heading here:
#59996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Feature] Block bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block Bindings: empty state of custom field can cause SEO problem

3 participants

@dhananjaykuber @carolinan @Mamaduka