Fix: Site Editor Template part is missing an icon in the sidebar#68653
Merged
Mamaduka merged 4 commits intoWordPress:trunkfrom Jan 15, 2025
Merged
Fix: Site Editor Template part is missing an icon in the sidebar#68653Mamaduka merged 4 commits intoWordPress:trunkfrom
Mamaduka merged 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Jan 14, 2025
Mamaduka
reviewed
Jan 14, 2025
Mamaduka
reviewed
Jan 14, 2025
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
…dPress#68653) Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…dPress#68653) Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68649
What?
Fixes the missing icon display for Template Parts in the Site Editor's document settings sidebar by implementing proper icon mapping for template part areas.
Why?
After #66459, the document settings sidebar stopped displaying icons for Template Parts because the icon value returned from default_template_part_areas was a string that wasn't properly mapped to a WordPress icon component. This PR restores the icon display functionality.
Testing Instructions
Screenshots or screencast