Resolve console error when using "Sort by" or "Order by" on Patterns page#68565
Closed
devansh016 wants to merge 2 commits intoWordPress:trunkfrom
Closed
Resolve console error when using "Sort by" or "Order by" on Patterns page#68565devansh016 wants to merge 2 commits intoWordPress:trunkfrom
devansh016 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…erns page by adding a null check for contentDocument.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
6 tasks
t-hamano
added
[Type] Bug
t-hamano
reviewed
Apr 2, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Hi @devansh016, thanks for the PR.
As discussed in #68562, we might need to investigate the underlying issue a bit more.
Let's close this PR for now and continue our exploration in #68562.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves a console error that occurs when interacting with the "Sort by" or "Order by" dropdowns on the Patterns page. A null check for
contentDocumenthas been added to ensure iframe initialization happens only after the iframe content is fully loaded.Why?
The error prevents the proper functioning of the Patterns page, impacting the user experience. This issue was reproducible across multiple themes and environments, as detailed in the related issue.
Related Issue: #68562
How?
The fix introduces a null check for
contentDocumentin the iframe initialization logic. This ensures that operations on the iframe are only executed when its content is available, preventing theTypeErrorthat previously occurred.Introduced in #38855 ( since we no longer try to initialise the iframe before the load event) another reference #51003
Testing Instructions
Screenshots or screencast