Skip to content

Navigation Submenu: Add Border and Spacing support - #68455

Open
dhruvikpatel18 wants to merge 2 commits into
WordPress:trunkfrom
dhruvikpatel18:add/navigation-submenu-border-support
Open

Navigation Submenu: Add Border and Spacing support#68455
dhruvikpatel18 wants to merge 2 commits into
WordPress:trunkfrom
dhruvikpatel18:add/navigation-submenu-border-support

Conversation

@dhruvikpatel18

@dhruvikpatel18 dhruvikpatel18 commented Jan 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What?

Add border and spacing block support to the Navigation Submenu block.

Why?

Navigation Submenu block is missing border and spacing support.
Part of #43247
Part of #43243

How?

Adds the border and spacing block support in block.json

Testing Instructions

  • Go to Global Styles Settings. ( Under Appearance > Editor > Styles > Edit styles > Blocks )
  • Ensure the Navigation Submenu block’s border and spacing are configurable via Global Styles.
  • Confirm Global Styles apply correctly in both the Editor and Frontend.
  • Open the Page or Template where you want to add the menu.
  • Add a Navigation block (the container block for all navigation links and Submenus).
  • Within the Navigation block, add Submenu block.
  • Verify Border, Radius, and Spacing settings are available for this Submenu block.
  • Check that block-specific styles (e.g., borders, spacing) take precedence over Global Styles.
  • Ensure borders and spacing display correctly in both the Editor and Frontend.

Screenshots or screencast

Submenu.block.mov

@dhruvikpatel18
dhruvikpatel18 marked this pull request as ready for review January 3, 2025 05:46
@github-actions

github-actions Bot commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @dhruvikmalaviya@Dhruviks-Mac.local.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: dhruvikmalaviya@Dhruviks-Mac.local.

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This was referenced Jan 5, 2025
Closed
Closed
@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jan 12, 2025
@carolinan

carolinan commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

The shared video shows inconsistencies between the editor and the front, including missing borders and borders being covered by the submenu items. I think users will be confused and will find it more difficult to use the option if the editor does not look the same.

Submenus that have submenus nested inside also needs to be tested carefully.

@carolinan carolinan added the [Block] Submenu Affects the Submenu Block - for submenus in navigation label Jan 23, 2025
@carolinan carolinan mentioned this pull request Feb 24, 2025
Open
@aaronrobertshaw aaronrobertshaw mentioned this pull request Sep 8, 2026
Open
@aaronrobertshaw aaronrobertshaw mentioned this pull request Sep 21, 2026
Merged

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner
@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner
@ndiego ndiego Awaiting requested review from ndiego

At least 1 approving review is required to merge this pull request.

Assignees

@dhruvikpatel18 dhruvikpatel18

Labels

[Block] Submenu Affects the Submenu Block - for submenus in navigation [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhruvikpatel18 @carolinan @shail-mehta