Post Comments Link: Add Border Support#68450
Merged
shail-mehta merged 1 commit intotrunkfrom Jan 2, 2025
Merged
Conversation
shail-mehta
added
[Type] Enhancement
shail-mehta
changed the title
|
Size Change: +172 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Jan 2, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
I tested global styles, block styles. Looks good in the editor and frontend.
Thanks!
|
Flaky tests detected in 5e28892. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12572205143
|
Member
Author
|
Thank you for the review. |
Contributor
|
The current design direction is that the default controls for border support should match any current adoption of spacing supports and their default controls. In other words, if the padding/margin controls show by default, so should the border controls. @shail-mehta can you submit another PR that fixes the default display of border controls here? |
Member
Author
|
Created PR to Show Border Control Default: PR |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Jan 8, 2025
Co-authored-by: shail-mehta <shailu25@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
Co-authored-by: shail-mehta <shailu25@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add border support to the
Post Comments Linkblock.Part of #43247
Why?
Post Comments Linkblock is missing border support.How?
Add the border support in block.json.
Testing Instructions
Post Comments Linkblock's border is Configurable via Global Styles.Archive Template& AddPost Comments Linkblock and Apply the border Styles.Post Comments Linkblock styles take precedence over global Styles.Post Comments Linkblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
post-comment-link.mp4