Remove isPressEnterToChange from TimePicker#68170
Open
prasadkarmalkar wants to merge 2 commits intoWordPress:trunkfrom
Open
Remove isPressEnterToChange from TimePicker#68170prasadkarmalkar wants to merge 2 commits intoWordPress:trunkfrom
prasadkarmalkar wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Package] Components
ntsekouras
added
[Package] Editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the isPressEnterToChange from Day and Year component of TimePicker
Why?
As in the #68148 issue the datetime is only getting updated when we change via navigation buttons or by clicking outside of the input of day and year.
How?
By removing isPressEnterToChange property from DayInput and YearInput component.
Screenshots or screencast
Screen.Recording.2024-12-20.at.1.09.38.PM.mov
Issue URL - #68148