Date Block: Add dropdown menu props to ToolsPanel component #68018
Conversation
|
Hi @fabiankaegy, This PR follows up on adding dropdown menu props to the ToolsPanel. The initial changes have already been merged. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
added
[Type] Enhancement
|
@Sukhendu2002 It looks like #67906 also introduced some issue with the spacing here: Before
After
The text 'Choose a format' is very close to the example text. Is that something you'd be able to fix in this PR as well? |
|
Hi @talldan, Good catch! Thanks for pointing that out. I'm already looking into it and will include a fix for the spacing issue in this PR as well. 😊 |
packages/block-editor/src/components/block-inspector/style.scss
Outdated
Show resolved
Hide resolved
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thanks for addressing the requested changes!
|
@Sukhendu2002 It looks like @t-hamano has recently fixed the styling issues in a separate PR that's been merged - #68079. 😄 Looks like you're already on top of it with a couple of recent commits. |
|
Yes, I think just adding the |
|
Looks like the spacing is too big now, so I agree, the CSS changes in this PR can be removed again 😄 |
|
@talldan I've removed the unnecessary CSS. Feel free to take a look when you have a moment! |
|
Looks perfect now, thanks for your patience! |
…s#68018) * Date Block: Add dropdown menu props to ToolsPanel component * Fix Default formate spacing issue * Update DateFormatPicker component style * Fix CSS indentation * Remove unnecessary CSS ---- Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
4 participants
Follow up of: #67906
What?
Enhances the Date block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.
Screenshots or screencast