Skip to content

Conversation

@im3dabasia
Copy link
Contributor

Follows up: #67958

What?

Enhances the Query Page Numbers block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.

Screenshots or screencast

Before After
Screenshot 2024-12-16 at 1 29 40 PM Screenshot 2024-12-16 at 1 29 52 PM

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hey @fabiankaegy,

Would it be a good idea to create a single PR to add all the dropdown menu props? I realize it’s going to take a lot of PRs, and this fix can be done in one PR. What do you think about this? If you agree, I can create a single PR to fix this for all the PRs that have already been merged.

Thank you

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block labels Dec 16, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this follow up :)

@fabiankaegy fabiankaegy enabled auto-merge (squash) December 16, 2024 08:29
@fabiankaegy fabiankaegy merged commit 7244968 into WordPress:trunk Dec 16, 2024
68 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 16, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…ordPress#68013)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy < fabiankaegy@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…ordPress#68013)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy < fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants