CSP: Refactor accessibility scripts to use Object.assign for style attributes#67988
Open
huubl wants to merge 1 commit intoWordPress:trunkfrom
Open
CSP: Refactor accessibility scripts to use Object.assign for style attributes#67988huubl wants to merge 1 commit intoWordPress:trunkfrom
huubl wants to merge 1 commit intoWordPress:trunkfrom
Conversation
The Object.assign() method modifies individual CSS properties through the JavaScript API, which is not blocked by Content Security Policy (CSP) without the 'unsafe-inline' directive. In contrast, setAttribute('style', '...') is considered an inline style and would be blocked by CSP without 'unsafe-inline'.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor: Use Object.assign to set inline style
More info:
#68021
Why?
This change will not be blocked by a CSP without unsafe-inline.
How?
The implementation replaces the existing
setAttributecall withObject.assign, applying individual style properties to the element'sstyleobject.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast