Skip to content

iAPI Router: Handle styles assets on region-based navigation #67826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 20, 2024
Merged

iAPI Router: Handle styles assets on region-based navigation #67826

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
67de97b
Experiment with
DAreRodz Nov 25, 2024
c50b033
Handle relative URLs
DAreRodz Nov 27, 2024
f9de8b4
Rename constructor to factory
DAreRodz Nov 27, 2024
fcf25c1
Use `element.sheet` property if present
DAreRodz Dec 2, 2024
777118b
Remove unnecessary files
DAreRodz Dec 11, 2024
e31e670
Remove extraneous param from tsdoc comment
DAreRodz Dec 11, 2024
86a48be
Allow inner blocks in `addPostWithBlock` util
DAreRodz Dec 15, 2024
2a8f7f8
Add test blocks for testing styles
DAreRodz Dec 15, 2024
356e7f3
Fix directives in region block
DAreRodz Dec 15, 2024
08046a0
Add styles to navigation counter
DAreRodz Dec 15, 2024
5656860
Implement first test
DAreRodz Dec 15, 2024
02abf7d
Add more tests WIP
DAreRodz Dec 16, 2024
05a5ec3
Refactor test block to make them easier to understand WIP
DAreRodz Dec 16, 2024
98d5076
Keep refactoring test blocks
DAreRodz Dec 16, 2024
79434be
Greatly simplify tests
DAreRodz Dec 16, 2024
c8bac0f
Test support for referenced style sheets
DAreRodz Dec 16, 2024
76841c7
Fix style files
DAreRodz Dec 16, 2024
ec301ef
Make HTML more clear
DAreRodz Dec 16, 2024
bcdbe32
Add test for relative URLs
DAreRodz Dec 16, 2024
43e66d8
Add tests for modified inline style tags
DAreRodz Dec 16, 2024
b78c8b1
Use text content instead of the id to identify inline style tags
DAreRodz Dec 16, 2024
769342b
Fix typo in comments
DAreRodz Dec 17, 2024
a423826
Fix e2e interactivity utils
DAreRodz Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make HTML more clear
  • Loading branch information
@DAreRodz
DAreRodz committed Dec 16, 2024
commit ec301ef068e1e7a2d84cde06ed2b8906acea50f7
10 changes: 6 additions & 4 deletions packages/e2e-tests/plugins/interactive-blocks/router-styles-wrapper/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,21 @@
?>
<div <?php echo $wrapper_attributes; ?>>
<!-- These get colored when the corresponding block is present. -->
<div>
<fieldset>
<legend>Styles from block styles</legend>
<p data-testid="red" class="red">Red</p>
<p data-testid="green" class="green">Green</p>
<p data-testid="blue" class="blue">Blue</p>
<p data-testid="all" class="red green blue">All</p>
</div>
</fieldset>
<!-- These get colored when the corresponding block enqueues a referenced stylesheet. -->
<div>
<fieldset>
<legend>Styles from referenced style sheets</legend>
<p data-testid="red-from-link" class="red-from-link">Red from link</p>
<p data-testid="green-from-link" class="green-from-link">Green from link</p>
<p data-testid="blue-from-link" class="blue-from-link">Blue from link</p>
<p data-testid="all-from-link" class="red-from-link green-from-link blue-from-link">All from link</p>
</div>
</fieldset>

<!-- Links to pages with different blocks combination. -->
<nav data-wp-interactive="test/router-styles">
Expand Down
Loading