Repository navigation
Add confirm dialog before Permanently delete - #67824
Merged
ntsekouras merged 19 commits intoDec 20, 2024
Merged
ntsekouras merged 19 commits into
ntsekouras merged 19 commits into
Conversation
This reverts commit 63f81c1.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
@karthick-murugan, entity actions already have built-in support for confirmation modals. See |
Mamaduka
requested review from
jorgefilipecosta and
youknowriad
and removed request for
youknowriad
December 12, 2024 06:48
Mamaduka
added
[Type] Bug
ntsekouras
reviewed
Dec 20, 2024
ntsekouras
approved these changes
Dec 20, 2024
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you!
ntsekouras
changed the title
ntsekouras
enabled auto-merge (squash)
December 20, 2024 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60383, where the "Permanently Delete" action for trashed posts in the WordPress editor was not functioning as expected. This PR improves the logic and introduces a confirmation modal to ensure users can confirm their actions before permanently deleting posts.
Why?
The current implementation of the "Permanently Delete" action did not provide a clear user experience and lacked safeguards like a confirmation modal. This could lead to unintentional deletions. By addressing this issue, the PR ensures a better and more accessible user experience while reducing the likelihood of errors.
How?
Added a modal confirmation step to confirm the deletion of selected posts.
Testing Instructions
Screenshots or screencast
REC-20241211165122.mp4