Stylebook: avoid double line in subcategory titles#67752
Stylebook: avoid double line in subcategory titles#67752matiasbenedetto merged 3 commits intotrunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Type] Bug
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this! LGTM ✅
|
The border should be above, so this is not quite right:
Admittedly trunk looks like this:
But the fix is to remove the "border-bottom" from here: That makes it look as intended: If you can update that, let's land this and thank you! |
This reverts commit bb96d6b.
Fixed in the latest commit. Thanks.
|
|
Nice! 🚢 |
* avoid double line in titles * Revert "avoid double line in titles" This reverts commit bb96d6b. * use only border top Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
3 participants
What?
Stylebook: avoid double lines in subcategory titles
Why?
Fixes a visual regression presumably introduced in #67546
How?
CSS adjustments.
Testing Instructions
Navigate to the 'theme' tab of the stylebook and observe the titles.
Screenshots or screencast