Size Change: +299 B (+0.02%)

Total Size: 1.84 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @bwoester, @fosterTerence, @Taruks, @AlternNO, @woodz-, @jennsuzhoy, @clarklab, @clo123, @SkipperPit, @alinekeller, @ToniSHernandez, @danwpc, @samrhein, @imsimplyellie, @gregoirenoyelle, @eriwm, @matthiasballreich, @random-pixels, @nicktrosnant, @cparkinson, @eilarva, @NolanDolce, @JohanVNR, @androos, @Fturttle.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: bwoester, fosterTerence, Taruks, AlternNO, woodz-, jennsuzhoy, clarklab, clo123, SkipperPit, alinekeller, ToniSHernandez, danwpc, samrhein, imsimplyellie, gregoirenoyelle, eriwm, matthiasballreich, random-pixels, nicktrosnant, cparkinson, eilarva, NolanDolce, JohanVNR, androos, Fturttle.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: stian-overasen <soverasen@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: paaljoachim <paaljoachim@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: cr0ybot <cr0ybot@git.wordpress.org>
Co-authored-by: timnolte <tnolte@git.wordpress.org>
Co-authored-by: ajmaurya99 <ajmaurya@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: davidoclubb <brigdonnwr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Thanks for working on this. I think this could do with design feedback (cc @WordPress/gutenberg-design).

Some questions:

• Should the captions be centred?
• Should the captions be more like the gallery block, where they're over the image? This way it doesn't visually break layouts

When adding media from Openverse, I believe the caption should be on by default to show the credit (I think it works this way for other media blocks already).

The final thing is that theme.json caption element support will I think be needed for this, though I personally don't know much about it.

Nice one.

For the first iteration here, I'd make captions consistent with every other caption, such as those on video and image. It's close:

But those other blocks come with a built in top and bottom margin, like so:

We need something similar for media & text.

Centering is something that a theme designer/developer should be able to do. Whether that happens through elements becoming stylable in global styles (I believe there's a separate issue tracking this), or the Caption becoming an innerblock (#54787). Though for now, I'd ensure consistency with other captions.

Thank you for working on this @akasunil Sunil!

When adding media from Openverse, I believe the caption should be on by default to show the credit (I think it works this way for other media blocks already).

It works for media-text blocks too.

Flaky tests detected in b2b0f39.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12632784883
📝 Reported issues:

• [Flaky Test] Navigates the items list via UP/DOWN arrow keys #64334 in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js
• [Flaky Test] blocks with bindings in a synced pattern are editable, and all other blocks are disabled #67492 in /test/e2e/specs/editor/various/pattern-overrides.spec.js

Removing needs design feedback label, as @jasmussen have answered all questions.

I think the hardest thing is whether to show the caption when the "Use featured image" is enabled.

It should be the same result as any other blocks that support featured image and caption.

It should be the same result as any other blocks that support featured image and caption.

The only other block that supports featured image is the Cover block, but that block doesn't have a caption. Therefore, we need to consider a new ideal behavior for the Media & Text block.

Do you have any good ideas on this?

Can we use extra block attribute for this?

The caption can not be edited when the featured image setting is used. If there is no caption in the media library, the default text "Add caption" shows. This is confusing because you can't follow the instructions.

Where is the caption supposed to be positioned when the "Crop image to fill" option is used?
Now the placeholder text "Add caption" is on top of the image, in the top left corner. When I click on it to start typing my caption text, it disappears. I did not research further, but I suspect it is now under the image.
The richtext toolbar for the caption covers the block toolbar.
When I save, the caption is not visible on the front of the site.

Text overlaying images has a high risk of becoming unreadable, depending on what the image looks like and what the colors are.