Fix: write mode is enabled after disabling the experiment#67463
Merged
SantosGuillamot merged 1 commit intotrunkfrom Dec 2, 2024
Merged
Fix: write mode is enabled after disabling the experiment#67463SantosGuillamot merged 1 commit intotrunkfrom
SantosGuillamot merged 1 commit intotrunkfrom
Conversation
SantosGuillamot
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8ffd6fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12116715971
|
getdave
approved these changes
Dec 2, 2024
SantosGuillamot
deleted the
fix/disable-write-mode-when-experiment-is-disabled
branch
Contributor
|
I am confused: Now that I disable the experiment, I can choose Design mode instead of Write mode. Meaning, I am not stuck anymore, but I am expecting it to be disabled. |
Contributor
Author
|
Mmm, that's not what I see in my testing 🤔 When the experiment is disabled, I can't choose between mode and "Design" is always activated. This is basically what I am doing:
If I understand you correctly, you are doing exactly the same but in the last step the "Write" mode keeps enabled and the Tools icon is there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
There is an issue where the "Write" mode remains enabled even after deactivating the experiment. This PR aims to fix that.
Why?
It is an unexpected behavior.
How?
Use the
isNavigationModehelper function instead of directly checking the preference. This helper checks if the experiment is enabled or not.Testing Instructions