Simplify description and option names in the Lock modal dialog#67437
Simplify description and option names in the Lock modal dialog#67437t-hamano merged 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
In order to resolve the E2E test failure, could you also update the strings Disable movement and Prevent removal contained in the following files?
- test/e2e/specs/editor/blocks/columns.spec.js
- test/e2e/specs/editor/various/block-locking.spec.js
- test/e2e/specs/editor/various/block-switcher.spec.js
|
Thanks for the PR! One of the points from the issue #62843 is that this text is now the legend of a fieldset element. It's too long to be a legend, it would be nice to make it way shorter. What about something along the lines of |
|
|
|
@t-hamano I wanted to know whether I should also change the test title string? |
Thanks for the PR! I think the title of the test is fine as is. |
|
Okay the I guess we are good to merge. |
afercia
left a comment
There was a problem hiding this comment.
Only point left is adjusting the legend text
|
To me, the only thing left is to improve the legend text. The current one:
'Choose the features to lock' or 'Choose the features to lock' would be more appropriate. |
|
@afercia & @t-hamano referring to this comment Between the two, "Select the features you want to lock" sounds better. "Select the features you want to lock" sounds better because it’s clearer and more user-friendly. It feels more personal by saying "you want to lock," which puts the focus on the user’s choice. It also uses the word "select," which is a common term in apps or websites, so it feels natural if someone is clicking or choosing something on a screen. On the other hand, "Choose the features to lock" is shorter but a bit vague. It doesn’t feel as specific or connected to the user. |
|
"Select the features you want to lock" sounds good to me. |
|
@sarthaknagoshe2002 Thanks for the update! Based on the discussion so far, this PR looks ready to ship 👍 |
This PR has been updated based on the feedback


Fixes: #62843
What?
This PR simplifies the description and renames the options in the Lock modal dialog to make the interface clearer and more intuitive for users.
Why?
The original description was too long and confusing, with mismatched visuals and terminology that added cognitive load. Additionally, the varying verbs for options were inconsistent and unnecessary. Simplifying the language and standardizing the option names enhances user understanding.
How?
Testing Instructions
Screenshots or screencast