Fix: Don't show aria-label when its value is empty#67381
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 8f952e0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12066203988
|
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
What?
Fixes an accessibility issue reported here.
Why?
aria-labelshouldn't be present when its value is empty.How?
Checking if it is empty before passing it as an extra attribute.
Testing Instructions
navelement.aria-labelis not there. Previously, it was without any value.