Skip to content

FontCollection: Update pagination controls#67143

Merged
matiasbenedetto merged 1 commit intoWordPress:trunkfrom
yogeshbhutkar:67123-unify-font-navigation
Nov 28, 2024
Merged

FontCollection: Update pagination controls#67143
matiasbenedetto merged 1 commit intoWordPress:trunkfrom
yogeshbhutkar:67123-unify-font-navigation

Conversation

@yogeshbhutkar
Copy link
Copy Markdown
Contributor

@yogeshbhutkar yogeshbhutkar commented Nov 20, 2024 •
edited
Loading

Fixes: #67123

What?

This PR unifies the navigation styles between Data Views and Font Navigation by updating the Pagination Code inside Font Navigation to match that of Data Views, enhancing visual consistency and defragmenting the user experience as mentioned in the issue.

Why?

Currently, the Font Navigation looks different from the Data Views Navigation. This PR brings consistency to both.

Testing Instructions

  1. Head over to Editor -> Styles -> Typography -> Install Fonts.
  2. Observe the Navigation rendered in the footer of the dialog.

Screenshots or screencast

Screen.Recording.2024-11-20.at.10.36.00.AM.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review November 20, 2024 05:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added [Type] Enhancement A suggestion for improvement. [Feature] Font Library General Interface Parts of the UI which don't fall neatly under other labels. labels Nov 20, 2024
@matiasbenedetto matiasbenedetto self-requested a review November 28, 2024 16:28
matiasbenedetto
matiasbenedetto approved these changes Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@matiasbenedetto matiasbenedetto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

The code looks good and in-line with the dataviews pagination (https://github.com/wordpress/gutenberg/blob/trunk/packages/dataviews/src/components/dataviews-pagination/index.tsx)

Functionality is testing as expected on my end.

Screencast.from.2024-11-28.13-32-02.mp4

@matiasbenedetto matiasbenedetto added General Interface Parts of the UI which don't fall neatly under other labels. and removed General Interface Parts of the UI which don't fall neatly under other labels. labels Nov 28, 2024
@matiasbenedetto matiasbenedetto mentioned this pull request Nov 28, 2024
Closed
@matiasbenedetto matiasbenedetto merged commit 9c1446d into WordPress:trunk Nov 28, 2024
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Nov 28, 2024
im3dabasia pushed a commit to im3dabasia/gutenberg that referenced this pull request Dec 4, 2024
@yogeshbhutkar @juanfra @im3dabasia
FontCollection: Update pagination controls (WordPress#67143)
55ba3e1 
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
@yogeshbhutkar @juanfra @michalczaplinski
FontCollection: Update pagination controls (#67143)
46f638e 
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matiasbenedetto matiasbenedetto matiasbenedetto approved these changes

Assignees

No one assigned

Labels

[Feature] Font Library General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 19.9

Development

Successfully merging this pull request may close these issues.

Unify navigation styles between Data Views and font navigation

3 participants

@yogeshbhutkar @matiasbenedetto @juanfra