Menu.ItemHelpText: better line breaking by himanshupathak95 · Pull Request #67011 · WordPress/gutenberg

himanshupathak95 · 2024-11-14T14:26:08Z

What?

Changed CSS word-break property from break-all to break-word in meta fields for better text readability when content wraps.

Why?

Currently, text in meta fields breaks incorrectly within words (e.g., "white" breaks as "whit e") due to using break-all. This creates poor readability, especially for descriptions and long text content. Using break-word ensures text breaks at appropriate word boundaries.

Testing Instructions

Add this test code to create a custom post type with meta fields in functions.php in your theme:

function init_test_meta_fields() {
   register_post_type(
       'landmark',
       array(
           'label'        => 'Landmark',
           'public'       => true,
           'supports'     => array( 'title', 'editor', 'comments', 'revisions', 'trackbacks', 'author', 'excerpt', 'page-attributes', 'thumbnail', 'custom-fields', 'post-formats' ),
           'has_archive'  => true,
           'show_in_rest' => true,
       ),
   );
   register_meta(
       'post',
       'landmark_description',
       array(
           'object_subtype' => 'landmark',
           'label'          => 'Description',
           'show_in_rest'   => true,
           'single'         => true,
           'type'           => 'string',
           'default'        => 'Inspired by the Eiffel Tower, this red and white tower is one of Tokyo\'s most recognizable landmarks.',
       )
   );
}

add_action( 'init', 'init_test_meta_fields' );

Create a new Landmark post
Check the attributes >> content desctiption field in meta fields
Verify text now breaks correctly at word boundaries
Test with various content lengths including URLs and long words

Screenshots

Before word-break: break-all; :

After word-break: break-word; :

Changed break-all to use word-break for better readability.

github-actions · 2024-11-14T14:26:29Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-11-14T14:26:49Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @himanshupathak95! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

juanfra

Thanks for your PR @himanshupathak95

It's testing nicely to me.

Screen.Recording.2024-11-19.at.18.12.50.mov

Can you please add an entry on the unreleased section of the changelog for components?

mirka

We can see that the original rule was put in place (#63916) with a pretty specific case in mind — a URL with a hyphen in the middle, like https://m.media-amazon.com/images/M/MV5BOTI5ZTNkYWQtNDg2Mi00MTBmLTliMGItNTI5YWI5OTZkM2Y2XkEyXkFqcGdeQXVyNzU1NzE3NTg@._V1_QL75_UX500_CR0,47,500,281_.jpg.

I do understand that break-all is not acceptable for wrapping (even if it's fine for truncation) in normal text, so I think reverting to word-break: normal is sensible.

Though we will see non-ideal wrapping for certain URLs, I think it's an acceptable compromise as long as they don't overflow and break the container, as was the original intent of the break-all:

A URL with a hyphen wraps in an non-ideal way

cc @ciampo for a gut check.

mirka · 2024-11-19T22:47:29Z

 	line-height: 16px;
 	color: ${ LIGHTER_TEXT_COLOR };
-	word-break: break-all;
+	word-break: break-word;


word-break: break-word is deprecated, so we should use the non-deprecated equivalent:

Suggested change

word-break: break-word;

overflow-wrap: anywhere;

Hey @mirka, Thanks for the suggestion.

I have made the suggested changes. Please let me know if there is anything else that can be done.

Replace deprecated `word-break: break-word` with the modern equivalent `overflow-wrap: anywhere` to handle text wrapping. This change maintains the same text wrapping behavior while using the current standard CSS property.

himanshupathak95 · 2024-11-20T08:59:51Z

Can you please add an entry on the unreleased section of the changelog for components?

Hey @juanfra, Thanks for replying.

I am not really sure what entry is to be made. I'd really appreciate it if you could steer me in the right direction.

juanfra · 2024-11-20T10:29:02Z

I am not really sure what entry is to be made. I'd really appreciate it if you could steer me in the right direction.

@himanshupathak95 When making changes to WordPress components, it’s important to add a changelog entry in packages/components/CHANGELOG.md. At the top of this file, you’ll find an “Unreleased” section, which is where you should add your entry. This ensures the changes are included in the next release.

Within the “Unreleased” section, there are sub-sections like “Bug Fixes” and “Enhancements.” Add your entry under the most appropriate sub-section, following the standard format:

-   `ComponentName`: Description of the change ([#PR-ID](URL-OF-PR)).

himanshupathak95 · 2024-11-20T11:12:33Z

Thanks, @juanfra for the suggestion.

I have now added the appropriate entry in CHANGELOG.md.

Please let me know if there is anything else that can be done.

ciampo

The fix seems sensible to me, thank you for the ping @mirka !

Left a couple of minor comments, we can merge this PR once they are addressed

ciampo · 2024-11-20T13:35:42Z

 -   `ToggleGroupControl`: Fix active background for `0` value ([#66855](https://github.com/WordPress/gutenberg/pull/66855)).
 -   `SlotFill`: Fix a bug where a stale value of `fillProps` could be used ([#67000](https://github.com/WordPress/gutenberg/pull/67000)).
 -   `ColorPicker`: Add accessible label for copy button ([#67094](https://github.com/WordPress/gutenberg/pull/67094)).
+-   `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).


Nit: adding a dot to represent the current component name

Suggested change

- `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

ciampo · 2024-11-20T13:37:03Z

 -   `ToggleGroupControl`: Fix active background for `0` value ([#66855](https://github.com/WordPress/gutenberg/pull/66855)).
 -   `SlotFill`: Fix a bug where a stale value of `fillProps` could be used ([#67000](https://github.com/WordPress/gutenberg/pull/67000)).
 -   `ColorPicker`: Add accessible label for copy button ([#67094](https://github.com/WordPress/gutenberg/pull/67094)).
+-   `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).


Another nit, but I think that the ### Internal section would be more fitting for this CHANGELOG entry, given that the component is still a private API

Hey @ciampo, Thanks for the suggestions.

I have addressed all the feedback. Please let me know if there is anything else that can be done.

mirka

Looks good, thank you for the follow-ups!

Fix: Use break-word instead of break-all in attribute description

97951ac

Changed break-all to use word-break for better readability.

himanshupathak95 requested a review from ajitbohra as a code owner November 14, 2024 14:26

github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 14, 2024

im3dabasia mentioned this pull request Nov 14, 2024

Menu: Truncation breaks with break-all rather than break-word #66998

Closed

mirka assigned himanshupathak95 Nov 14, 2024

mirka requested a review from a team November 14, 2024 22:00

mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Nov 14, 2024

juanfra reviewed Nov 19, 2024

View reviewed changes

mirka reviewed Nov 19, 2024

View reviewed changes

himanshupathak95 added 2 commits November 20, 2024 14:15

CSS: Replace deprecated word-break with overflow-wrap

7c0d42e

Replace deprecated `word-break: break-word` with the modern equivalent `overflow-wrap: anywhere` to handle text wrapping. This change maintains the same text wrapping behavior while using the current standard CSS property.

Merge branch 'trunk' into fix/attribute-description-word-break-style

45245b7

himanshupathak95 requested review from juanfra and mirka November 20, 2024 09:00

Docs: Add changelog entry for MenuItemHelpText text wrapping fix

dfef21a

ciampo approved these changes Nov 20, 2024

View reviewed changes

ciampo changed the title ~~Fix: Use break-word instead of break-all in attribute description~~ Menu.ItemHelpText: better line breaking Nov 20, 2024

himanshupathak95 added 2 commits November 21, 2024 13:35

Docs: Update changelog entry for Menu.ItemHelpText to internal section

f825315

Merge branch 'trunk' into fix/attribute-description-word-break-style

b6424e3

himanshupathak95 requested a review from ciampo November 21, 2024 08:36

mirka approved these changes Nov 21, 2024

View reviewed changes

mirka merged commit 9a6f48b into WordPress:trunk Nov 21, 2024

github-actions Bot added this to the Gutenberg 19.8 milestone Nov 21, 2024

	- `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).
	- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

Conversation

himanshupathak95 commented Nov 14, 2024

What?

Why?

Testing Instructions

Screenshots

Uh oh!

github-actions Bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 14, 2024

Uh oh!

juanfra left a comment

Choose a reason for hiding this comment

Uh oh!

mirka left a comment

Choose a reason for hiding this comment

Uh oh!

mirka Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 commented Nov 20, 2024

Uh oh!

juanfra commented Nov 20, 2024

Uh oh!

himanshupathak95 commented Nov 20, 2024

Uh oh!

ciampo left a comment

Choose a reason for hiding this comment

Uh oh!

ciampo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

ciampo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

himanshupathak95 Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

mirka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Nov 14, 2024 •

edited

Loading