Skip to content

Home Link: Add border, color and spacing - #66902

Open
yogeshbhutkar wants to merge 2 commits into
WordPress:trunkfrom
yogeshbhutkar:66901-home-link-customization
Open

yogeshbhutkar wants to merge 2 commits into
WordPress:trunkfrom
yogeshbhutkar:66901-home-link-customization

Conversation

@yogeshbhutkar

@yogeshbhutkar yogeshbhutkar commented Nov 11, 2024 •

Copy link
Copy Markdown
Contributor

Fixes: #66901
Part of: #43247

What?

Added the support for Border Radius, Color ( Background, Text ), and Spacing ( Margin and Padding ) to the Home Link Block.

Why?

It will enhance the customizability of the Home Link Block by letting the users add border-radius, custom colors and spacings.

How?

block.json corresponding to the Home Link block is updated with above mentioned configurations.

Testing Instructions

  1. Open a page.
  2. Add a navigation component.
  3. Insert a Home Link block inside it.
  4. Try customizing the Home Link block.

Screenshots or screencast

Screen.Recording.2024-11-11.at.2.10.45.PM.mov

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 11, 2024
@github-actions

Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yogeshbhutkar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@yogeshbhutkar
yogeshbhutkar marked this pull request as ready for review November 11, 2024 08:42
@akasunil akasunil added the [Type] Enhancement A suggestion for improvement. label Nov 12, 2024
@t-hamano t-hamano added the [Block] Home Link Affects the Home Link Block label Nov 13, 2024
@carolinan

Copy link
Copy Markdown
Contributor

Hi @yogeshbhutkar
I tried to test this but the build process keeps failing, I think it may need to be rebased, to include the latest changes from trunk.

@yogeshbhutkar
yogeshbhutkar force-pushed the 66901-home-link-customization branch from 9fb9858 to 00c12b7 Compare February 21, 2025 10:32
@yogeshbhutkar yogeshbhutkar changed the title Home Link: Enhance home link block support for customizations Home Link: Add border, color and spacing Feb 21, 2025
@yogeshbhutkar

Copy link
Copy Markdown
Contributor Author

Hi @carolinan,
I've rebased the PR and refreshed the patch. It should test well now. Can you please check?

@carolinan

Copy link
Copy Markdown
Contributor

I don't think this should be added until there is a final decision about what style options the inner blocks on the navigation block should have. Because if it is only added to the home link, then the home links become inconsistent with the other links, that do not have these options.
The home link can only be used inside the navigation block. If it could be used outside it, then changing only this block would make more sense.

@carolinan carolinan added the Needs Design Feedback Needs general design feedback. label Feb 27, 2025
@mrleemon

mrleemon commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

#83607 and #83360 added spacing and border support to the Home Link block.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: mrleemon <leemon@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Home Link Affects the Home Link Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home Link: Add Color and Radius support to Home Link Navigation element

5 participants