Skip to content

Fix: Navigate to entity breaks when postType is not loaded #66710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix: Navigate to entity breaks when postType is not loaded #66710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e73668
Wait until postType is loaded
SantosGuillamot Nov 4, 2024
b146949
Use `useRegistry` hook
SantosGuillamot Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Wait until postType is loaded
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Nov 4, 2024
commit 0e73668eb0e0db2d64e362dc239dbdd419cd8952
13 changes: 10 additions & 3 deletions packages/edit-post/src/hooks/use-navigate-to-entity-record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
* WordPress dependencies
*/
import { useCallback, useReducer } from '@wordpress/element';
import { useSelect, useDispatch } from '@wordpress/data';
import { store as coreStore } from '@wordpress/core-data';
import { resolveSelect, useSelect, useDispatch } from '@wordpress/data';
import { store as editorStore } from '@wordpress/editor';

/**
Expand Down Expand Up @@ -52,7 +53,8 @@ export default function useNavigateToEntityRecord(
const { setRenderingMode } = useDispatch( editorStore );

const onNavigateToEntityRecord = useCallback(
( params ) => {
async ( params ) => {
await resolveSelect( coreStore ).getPostType( params.postType );
dispatch( {
type: 'push',
post: { postId: params.postId, postType: params.postType },
Expand All @@ -61,7 +63,12 @@ export default function useNavigateToEntityRecord(
} );
setRenderingMode( defaultRenderingMode );
},
[ getRenderingMode, setRenderingMode, defaultRenderingMode ]
[
resolveSelect,
getRenderingMode,
setRenderingMode,
defaultRenderingMode,
]
);

const onNavigateToPreviousEntityRecord = useCallback( () => {
Expand Down
Loading