Implement validation slug #66676
Closed
Implement validation slug #66676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +415 B (+0.02%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d021369. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11630842411
|
gigitux
force-pushed
the
add/validation-slug-field
branch
from
153f9d5 to
04e08cf
Compare
Contributor
Author
|
Closing in favor of #67357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds validation for the slug field, displaying an error message when the field is empty.
Changes
isValidcallback arguments:getValuefunction).getValuefunction.While this approach works for the slug field, it misses a few key points crucial for extensibility, particularly for generic fields:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast