Navigation Link: Add Border and Spacing support - #66483

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano - Please have a look at this PR, when you get some time.

@aaronrobertshaw Is this one worth refreshing?

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

Thanks for the PR @karthick-murugan, and thanks for the nudge @jasmussen.

This one is stale and conflicts with trunk, so I'm closing it. I'll open two fresh PRs instead, one for border and one for spacing, so each can be reviewed on its own.

Before I do, there's a design question I'd like your take on, Joen. A Navigation Link is two things: the menu item, and the link inside it that you click. Navigation already sets the link's padding itself.

1. Should padding support make the clickable link bigger, or add space around the item?
2. Should a border wrap the link, or the whole item?
3. Should these values also show inside submenus and in the mobile overlay menu, or only in the main bar?

My leaning is that both should apply to the link, so the visible box and the clickable area match. That's an opinion though, and I'm happy to go the other way.