Repository navigation
Query Pagination Previous: Add border and spacing support - #66393
karthick-murugan wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for the PR @karthick-murugan 👍
I've taken this for a spin on a local rebase onto trunk, testing borders and padding through Global Styles, a block instance value, and both again at different viewports, as well as resetting controls.
✅ Border and Padding work in the editor and on the frontend
✅ A block instance value overrides Global Styles
Before we merge this though I think there are a couple of things to address.
Rebase
docs/reference-guides/core-blocks.md has since moved to docs/reference-guides/core-blocks/README.md, and the block now has its own generated README.md. Running npm run docs:build after the rebase will update both.
Margin support
- This block always renders inside the Query Pagination flex container
- The flex layout resets child margins with
.is-layout-flex > :is(*, div) { margin: 0 } - That reset wins over the
:root :where(...)that Global Styles outputs - So a margin set in Global Styles does nothing here
- A block instance right margin does apply, but it replaces the
margin-inline-end: autothat "Space between" relies on, so the other links shift
Padding is ok. The space between pagination links belongs to the container. core/buttons, core/social-links and core/navigation all put blockGap on the parent and keep margin off the children. core/button itself only adopts padding and border.
Query Pagination has no blockGap support yet but I will raise a PR for that separately.
Box sizing
It'd be worth adding a style.scss with box-sizing: border-box while you're here, as Comment Edit Link and Post Navigation Link do. #64308 and #64310 add the same rule to the Comments Pagination links.
Testing note: the Previous link only renders from the second page onwards, so check the frontend with ?query-<id>-page=2 on the URL.
Border screenshots
Padding screenshots
What?
Add border and spacing block support to the Query Pagination Previous ( Previous Page ) block.
Part of #43247
Part of #43243
Why?
Query Pagination Previous ( Previous Page )block is missing border and spacing support.How?
Adds the border and spacing block support in block.json
Testing Instructions
Testing Instructions for Keyboard
None.
Screenshots or screencast
In Backend:
In Front End: