Skip to content

Query Pagination Previous: Add border and spacing support - #66393

Open
karthick-murugan wants to merge 3 commits into
WordPress:trunkfrom
karthick-murugan:add/query-pagination-previous-border-support
Open

karthick-murugan wants to merge 3 commits into
WordPress:trunkfrom
karthick-murugan:add/query-pagination-previous-border-support

Conversation

@karthick-murugan

@karthick-murugan karthick-murugan commented Oct 24, 2024 •

Copy link
Copy Markdown
Contributor

What?

Add border and spacing block support to the Query Pagination Previous ( Previous Page ) block.

Part of #43247
Part of #43243

Why?

Query Pagination Previous ( Previous Page ) block is missing border and spacing support.

How?

Adds the border and spacing block support in block.json

Testing Instructions

  • Go to Appearance > Editor > Styles > Edit Styles > Blocks.
  • Ensure the Query Pagination Previous (Previous Page) block's border and spacing is configurable via Global Styles.
  • Confirm Global Styles are applied correctly in both the editor and frontend.
  • Edit a template or page and add a Query Loop block.
  • Select a variation (e.g., Title & Date) and adjust pagination to display the "Previous Link."
  • Select the Previous Page block and verify border, radius and spacing settings are available.
  • Check that block styles take precedence over Global Styles.
  • Ensure borders and spacing display correctly in both the editor and frontend.

Testing Instructions for Keyboard

None.

Screenshots or screencast

In Backend:

query_prev_backend

In Front End:

query_prev_frontend

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 24, 2024
@github-actions

Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@karthick-murugan karthick-murugan changed the title Query Pagination Previous Border Support Query Pagination Previous: Add border and spacing support Oct 24, 2024
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block labels Oct 24, 2024

@aaronrobertshaw aaronrobertshaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @karthick-murugan 👍

I've taken this for a spin on a local rebase onto trunk, testing borders and padding through Global Styles, a block instance value, and both again at different viewports, as well as resetting controls.

✅ Border and Padding work in the editor and on the frontend
✅ A block instance value overrides Global Styles

Before we merge this though I think there are a couple of things to address.

Rebase

docs/reference-guides/core-blocks.md has since moved to docs/reference-guides/core-blocks/README.md, and the block now has its own generated README.md. Running npm run docs:build after the rebase will update both.

Margin support

  • This block always renders inside the Query Pagination flex container
  • The flex layout resets child margins with .is-layout-flex > :is(*, div) { margin: 0 }
  • That reset wins over the :root :where(...) that Global Styles outputs
  • So a margin set in Global Styles does nothing here
  • A block instance right margin does apply, but it replaces the margin-inline-end: auto that "Space between" relies on, so the other links shift

Padding is ok. The space between pagination links belongs to the container. core/buttons, core/social-links and core/navigation all put blockGap on the parent and keep margin off the children. core/button itself only adopts padding and border.

Query Pagination has no blockGap support yet but I will raise a PR for that separately.

Box sizing

It'd be worth adding a style.scss with box-sizing: border-box while you're here, as Comment Edit Link and Post Navigation Link do. #64308 and #64310 add the same rule to the Comments Pagination links.


Testing note: the Previous link only renders from the second page onwards, so check the frontend with ?query-<id>-page=2 on the URL.

Border screenshots

Image

Padding screenshots

Image

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants