Skip to content

Navigation: Add border and spacing support - #66392

Open
rinkalpagdar wants to merge 2 commits into
WordPress:trunkfrom
rinkalpagdar:add/navigation-border
Open

Navigation: Add border and spacing support#66392
rinkalpagdar wants to merge 2 commits into
WordPress:trunkfrom
rinkalpagdar:add/navigation-border

Conversation

@rinkalpagdar

@rinkalpagdar rinkalpagdar commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What?

Add border block support to the navigation block.
Part of #43247
Part of #43243

Why?

The Navigation block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  1. Go to the Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  2. Make sure that the navigation block's border is configurable via Global Styles
  3. Verify that Global Styles are applied correctly in the editor and frontend
  4. Edit the template/page, Add a Navigation block and Apply the border styles
  5. Verify that block styles take precedence over global styles
  6. Verify that block borders display correctly in both the editor and frontend

Note

Please confirm that we need a border for items and a wrapper for navigation as shown in the frontend image below.

Screenshots or screencast

FrontEnd:
navigation-front

Backend:
navigation-backend

@github-actions

github-actions Bot commented Oct 24, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 24, 2024
@github-actions

github-actions Bot commented Oct 24, 2024

Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rinkalpagdar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@rinkalpagdar rinkalpagdar changed the title navigation border added Navigation: Add border and spacing support Oct 24, 2024
@ndiego ndiego added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Oct 24, 2024
This was referenced Oct 24, 2024
Closed
Closed
@yogeshbhutkar yogeshbhutkar mentioned this pull request Feb 24, 2025
Closed
@aaronrobertshaw aaronrobertshaw mentioned this pull request Sep 8, 2026
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner
@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner
@ndiego ndiego Awaiting requested review from ndiego

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Block] Navigation Affects the Navigation Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rinkalpagdar @ndiego