Skip to content

Tabs: fix animation timings #66198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 3 commits into from
Oct 17, 2024
Merged

Tabs: fix animation timings #66198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f6a493
Tabs: fix animation timings
ciampo Oct 17, 2024
bc93ff0
CHANGELOG
ciampo Oct 17, 2024
d691045
Merge branch 'trunk' into fix/tabs-caret-animation
ciampo Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/block-editor/src/components/inserter/category-tabs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ function CategoryTabs( {

return (
<Tabs
className="block-editor-inserter__category-tabs"

@tyxla tyxla Oct 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

https://wpdirectory.net/search/01JAD1QEN6ZR91JYSVQPSHR50E

@ciampo ciampo Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have mentioned — applying a className to Tabs doesn't make any sense because Tabs doesn't render any element to the DOM (and doesn't accept a className prop at all)

selectOnMove={ false }
selectedTabId={ selectedCategory ? selectedCategory.name : null }
orientation="vertical"
Expand Down
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bug Fixes

- `Tabs`: fix indicator animation ([#66198](https://github.com/WordPress/gutenberg/pull/66198)).
- `ColorPalette`: prevent overflow of custom color button background ([#66152](https://github.com/WordPress/gutenberg/pull/66152)).

### Enhancements
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/tabs/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export const Tab = styled( Ariakit.Tab )`
opacity: 0;

@media not ( prefers-reduced-motion ) {
transition: opacity 0.15s 0.15s linear;
transition: opacity 0.1s linear;
}
}

Expand Down Expand Up @@ -253,7 +253,7 @@ export const TabChevron = styled( Icon )`
[data-select-on-move='true']
[role='tab']:is( [aria-selected='true'], )
& {
transition: opacity 0.3s ease-in;
transition: opacity 0.15s 0.15s linear;
}
}
&:dir( rtl ) {
Expand Down