Repository navigation
Tabs: fix animation timings - #66198
Merged
Merged
Conversation
ciampo
added
[Type] Bug
ciampo
marked this pull request as ready for review
October 17, 2024 10:23
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -11 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 17, 2024
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for fixing it!
Will need a rebase to solve the CHANGELOG conflicts.
|
|
||
| return ( | ||
| <Tabs | ||
| className="block-editor-inserter__category-tabs" |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I should have mentioned — applying a className to Tabs doesn't make any sense because Tabs doesn't render any element to the DOM (and doesn't accept a className prop at all)
ciampo
enabled auto-merge (squash)
October 17, 2024 14:41
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a bug introduced in #65387 (comment) related to
Tabsindicator animation.Why?
The bug was simply a mistake, where a transition spec was applied to the wrong place.
How?
By applying the transition styles as originally intended — see #65387 (comment)
Testing Instructions
Test the
Tabscomponent:selectOnMove={true}, the caret should appear with a delay, basically waiting for the indicator to animate in place before fading inScreenshots or screencast
Kapture.2024-10-17.at.12.20.45.mp4
Kapture.2024-10-17.at.12.22.24.mp4