Render all block patterns of the current page and remove async list#66114
Closed
madhusudhand wants to merge 1 commit intotrunkfrom
Closed
Render all block patterns of the current page and remove async list#66114madhusudhand wants to merge 1 commit intotrunkfrom
madhusudhand wants to merge 1 commit intotrunkfrom
Conversation
madhusudhand
requested review from
getdave,
kevin940726,
mikachan and
ramonjd
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
madhusudhand
added
[Type] Bug
|
Size Change: -79 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
This was referenced Oct 15, 2024
|
Flaky tests detected in 9a521f8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11341796853
|
Contributor
Does this fix a bug introduced during the 6.7 cycle? |
getdave
reviewed
Oct 15, 2024
| patternFilter={ patternSourceFilter } | ||
| pagingProps={ pagingProps } | ||
| /> | ||
| { pagingProps && ( |
Contributor
There was a problem hiding this comment.
Unless critical to this PR, then I'd suggest we take the changes that move Pagination and put in a separate PR.
Contributor
I'm slightly concerned about this as I know we've suffered poor performance rendering patterns. I wonder if we need to look again at how asyncList is working. From my tests I see to get inconsistent results with array lengths of:
I feel there could be an underlying bug here. |
Member
Author
|
This is no longer needed, as the rendering improved in #66159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is an alternate to #66053. (created a separate one because it has got a UI change)
fixes: #65920
Why?
I don't think an async pattern list is necessary anymore, because are patterns are already paginated.
Having async list causes patterns to render multiple times, which is negatively effecting the UI performance and experience.
This PR removes the async pattern list and renders all patterns of the current page (max 20).
Also moves the pagination block to a level up, so that It is always visible.
Why move pagination?
If not fixed at the bottom, pagination visible first at the top of the page, and pushed down once patterns render.
Not sure if that should be considered as enhancement. Hence creating a separate PR instead of updating #66053
Testing Instructions