Cherry pick "Block Bindings: Accept client ID as parameter for useBlockBindingsUtils (#65818)" to wp/6.7#66048
Merged
kevin940726 merged 1 commit intowp/6.7from Oct 14, 2024
Merged
Conversation
kevin940726
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
|
The failing tests are due to missing PR in Also there is no way to test this PR as the original PR didn't include any real testing steps. @SantosGuillamot could you verify this for us please? 🙏 |
…ils` (#65818) * Pass `clientId` to `useBlockBindingsUtils` * Add unit tests for `useBlockBindingsUtils` * Use `resetBlocks` instead of `insertBlocks` in unit test Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
kevin940726
force-pushed
the
fix/cherry-pick-65818
branch
from
e8444ce to
373adcc
Compare
Member
Author
|
The e2e tests are now passing and they should cover the original testing instructions as mentioned in the original PR. |
Contributor
|
Sorry for being late here, and thanks for taking care of it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why?
Manually cherry-pick #65818 to wp/6.7.
How?
Follow the steps in #65818 (comment).