Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 11e9edb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11031079156
|
|
Thanks for the cleanup 👍
I'll defer to @richtabor on this one as I believe he originally provided the icon. |
|
'square' is a curious name for this icon, should we change that or is it too late? |
I agree. I think |
|
|
|
I think so, but cc'in the WordPress 6.7 release tech leads to make sure @noisysocks @kevin940726 |
What?
The current code for the square icon introduced here included a fixed
strokeWidth="1.5"and other unecessary tags likestrokeLinecap="square". When pasted on Figma, the icon displays a width of1pxinstead of1.5px, by flattening we'll have a consistent line weight.This PR flattens the icon and also reduces its weight.
Testing Instructions
squareiconScreenshots
Here is the icon in context before and after: