Skip to content

Fix search box design issues and make it consistent.#65610

Open
viralsampat-multidots wants to merge 1 commit intoWordPress:trunkfrom
viralsampat-multidots:fix-search-block-design-issue-#65608
Open

Fix search box design issues and make it consistent.#65610
viralsampat-multidots wants to merge 1 commit intoWordPress:trunkfrom
viralsampat-multidots:fix-search-block-design-issue-#65608

Conversation

@viralsampat-multidots
Copy link
Copy Markdown
Contributor

What?

I have created this PR to add little bit gap between search button and input field when we choose button position to "Button Only".

Why?

I have reviewed the "Search Block" and found design consistent issue, When we change button position to "Button only", there is no gap between the search (or search icon) button and the input field. It looks inconsistent.

Testing Instructions

  • Add the Search block.
  • Choose the button position to "Button only" option
  • Update and visit the page.
  • Click on the Search button.

Testing Instructions for Keyboard

I have checked this changes into the local PC and its looks good.

Screenshots or screencast

Here, I have provided its screenshots:

Editor-end:
after-resolved-search-block-editor

Front-end:
after-resolved-search-block-front-end

Thanks,

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: viralsampat-multidots <mdviralsampat@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant