Update block-filters.md by davy440 · Pull Request #64959 · WordPress/gutenberg

davy440 · 2024-08-31T17:53:12Z

What?

Describing the blocks.getBlockAttributes filter

Why?

The documentation needed updation regarding the filter. It could be helpful exploring further applications of the filter hook.

How?

Currently, there is no documentation for the filter hook.

Testing Instructions

Set up the block development environment using @wordpress/scripts package.
Setup an entry-point for webpack in the package.
Add the code to the entry pint.
Save and compile.

Added description for `blocks.getBlockAttributes` filter

github-actions · 2024-08-31T17:53:29Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davy440 <indithemes@git.wordpress.org>
Co-authored-by: akasunil <sunil25393@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-08-31T17:53:37Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @davy440! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

akasunil · 2024-09-03T17:27:21Z

Thank you for your contribution!

Is it possible for us to utilize the same simple example function something like other filters example in the same readme? I think this one is a little too technical; since the purpose of this is just to show how to apply the filter, a simple function would do the job.

davy440

Modified the example and provided additional info

Explained the parameters accepted by the filter callback function.

Fixed parameter names.

davy440 · 2024-09-11T04:18:46Z

@akasunil Thanks for the feedback. I have modified the example and provided additional info regarding the filter.
Please review.

Thanks,
Divjot

akasunil · 2024-09-11T05:28:15Z

Thanks @davy440 for the ping. I have left couple of suggestions. Hope to get it addressed.

davy440 · 2024-09-11T12:31:07Z

@akasunil Yes, I have provided a simpler example in my most recent commit. Is there something else I'm missing?

docs/reference-guides/filters/block-filters.md

Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

davy440 · 2024-09-12T20:40:02Z

@akasunil thanks for the above fixes. Didn't pay attention to the above mentioned errors earlier.

akasunil

Thank you @davy440, These looks really good. just one final thing to address and then we are ready to go.

docs/reference-guides/filters/block-filters.md

Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

akasunil

LGTM!

davy440 · 2024-09-26T20:08:28Z

@akasunil Is there any update regarding the PR? Please let me know if anything is required from my end.

Thank you,
Divjot

akasunil · 2024-09-27T06:11:19Z

Hi @davy440 Can you sync the PR with trunk?

davy440 · 2024-09-28T02:56:43Z

@akasunil Just synced the fork with main branch. Showing 11 commits ahead of main branch. Let me know if anyhting else is required.

Thanks

* Update block-filters.md Added description for `blocks.getBlockAttributes` filter * Modified example and provided additional info * modified example and provided additional info Explained the parameters accepted by the filter callback function. * modified example and provided additional info Fixed parameter names. * Update docs/reference-guides/filters/block-filters.md Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> --------- Co-authored-by: davy440 <indithemes@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org>

This reverts commit 40eae5a.

* Update block-filters.md Added description for `blocks.getBlockAttributes` filter * Modified example and provided additional info * modified example and provided additional info Explained the parameters accepted by the filter callback function. * modified example and provided additional info Fixed parameter names. * Update docs/reference-guides/filters/block-filters.md Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> --------- Co-authored-by: davy440 <indithemes@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org>

Update block-filters.md

3c7f424

Added description for `blocks.getBlockAttributes` filter

davy440 requested review from ajitbohra, fabiankaegy, juanmaguitar and ndiego as code owners August 31, 2024 17:53

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 31, 2024

davy440 marked this pull request as draft August 31, 2024 19:12

davy440 marked this pull request as ready for review August 31, 2024 19:23

shail-mehta added the [Type] Developer Documentation Documentation for developers label Sep 1, 2024

davy440 commented Sep 11, 2024

View reviewed changes

davy440 added 3 commits September 11, 2024 00:05

Modified example and provided additional info

d645674

modified example and provided additional info

9485386

Explained the parameters accepted by the filter callback function.

modified example and provided additional info

ac26f84

Fixed parameter names.

akasunil requested changes Sep 12, 2024

View reviewed changes

davy440 and others added 5 commits September 12, 2024 16:31

Update docs/reference-guides/filters/block-filters.md

f645154

Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

Update docs/reference-guides/filters/block-filters.md

cd9e0f9

thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

Update docs/reference-guides/filters/block-filters.md

3039946

thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

Update docs/reference-guides/filters/block-filters.md

b459937

thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

Update docs/reference-guides/filters/block-filters.md

1517178

thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

davy440 requested a review from akasunil September 12, 2024 20:40

akasunil requested changes Sep 13, 2024

View reviewed changes

docs/reference-guides/filters/block-filters.md Outdated Show resolved Hide resolved

Update docs/reference-guides/filters/block-filters.md

503bdc3

Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com>

akasunil approved these changes Sep 20, 2024

View reviewed changes

Merge branch 'WordPress:trunk' into patch-1

409b676

akasunil merged commit 6f98f51 into WordPress:trunk Oct 1, 2024

github-actions bot added this to the Gutenberg 19.4 milestone Oct 1, 2024

huubl added a commit to huubl/gutenberg that referenced this pull request Oct 2, 2024

Revert "Update block-filters.md (WordPress#64959)"

ab634e9

This reverts commit 40eae5a.

draganescu mentioned this pull request Oct 2, 2024

Throwaway: merge content editing with toolbar anchoring #65844

Closed

Conversation

davy440 commented Aug 31, 2024

What?

Why?

How?

Testing Instructions

Uh oh!

github-actions bot commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 31, 2024

Uh oh!

akasunil commented Sep 3, 2024

Uh oh!

davy440 left a comment

Choose a reason for hiding this comment

Uh oh!

davy440 commented Sep 11, 2024

Uh oh!

akasunil commented Sep 11, 2024

Uh oh!

davy440 commented Sep 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davy440 commented Sep 12, 2024

Uh oh!

akasunil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akasunil left a comment

Choose a reason for hiding this comment

Uh oh!

davy440 commented Sep 26, 2024

Uh oh!

akasunil commented Sep 27, 2024

Uh oh!

davy440 commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Aug 31, 2024 •

edited

Loading